This was originally meant as a comment but was too long to be considered as such.
It's all a matter of convention but I would agree with you that there is a sign problem.
If you look at it from the perspective of the desk which makes the trade, CVA constitutes a cost (hence a negative amount) which, all other things equal, decreases the overall value of your portfolio once factored in.
To illustrate this, suppose you enter an uncollateralised long option trade with a counterparty. Further assume that this option has a positive payout in all states of the world, i.e. a positive premium (e.g. long call).
What happens then is that you are paying a certain amount of cash to the counterparty, in exchange for a promise of it delivering you the payout at the contract's expiry. You are thus exposed to the risk of that counterparty's defaulting on it's obligation, i.e. credit risk.
Say the option value is 100\$ in the market ("risk-free" value, in the sense: not counterparty dependent).
Using the above formula, you compute a CVA of -10\$. This number is negative since it is what you expect to lose should the counterparty default, i.e. what you won't get back on what it promised you at inception.
Assuming you pay the "risk-free" value for the option to the counterparty, your books accounting will most likely show the following new lines:
- Short 100\$ cash (premium paid)
- Long 100\$ worth of option ("risk-free" value of the deal)
- CVA cost of -10\$ (charge for credit risk, dependent on the CTP)
Such that you actually "lose" 10$ when the trade is made, due to the unprovisioned/unhedged credit risk you've just added to your books.
Knowing this, suppose you instead agree to pay to the counterparty a premium equal to "risk-free value + CVA", which is more in line with the real economic value of the trade from your perspective. You would then have:
- Short 90\$ cash (credit risk adjusted premium)
- Long 100\$ worth of option ("risk-free" value of the deal)
- CVA of -10\$ (CVA charge of the deal)
so that you end up being neutral once the deal is made.
This is usually how this happens in practice since there exists a separate XVA desk. Put differently, the desk which makes the option trade (e.g. an equity derivatives desk) values that trade at its "risk-free" value. However, it needs to adjust the premium quoted/paid for credit risk, in the form of a credit value adjustment, which is computed by a dedicated XVA desk, who shall later be in charge of managing the credit risk transferred to it.